Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP KML import feature #1279

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

WIP KML import feature #1279

wants to merge 10 commits into from

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Nov 9, 2023

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

42.0% 42.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@qdraw
Merge branch 'master' into feature/202311_kml_import
6e3c7a0 
# Conflicts:
#	starsky/starskytest/starsky.feature.geolookup/Services/GeoCliTest.cs
#	starsky/starskytest/starsky.feature.import/Services/ImportCliTest.cs
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (81d49a7) 94.77% compared to head (f91cf9e) 94.70%.
Report is 10 commits behind head on master.

❗ Current head f91cf9e differs from pull request most recent head 7a0076d. Consider uploading reports for the commit 7a0076d to get more accurate results

Files Patch % Lines
....foundation.georealtime/Models/KmlImportOptions.cs 0.00% 7 Missing ⚠️
...ation.georealtime/Helpers/Kml2IntermediateModel.cs 85.29% 1 Missing and 4 partials ⚠️
...ky.foundation.georealtime/Services/KmlImportCli.cs 0.00% 3 Missing ⚠️
....georealtime/Helpers/IntermediateModelConverter.cs 97.22% 0 Missing and 2 partials ⚠️
...arsky.foundation.georealtime/Services/KmlImport.cs 84.61% 1 Missing and 1 partial ⚠️
.../starsky.foundation.platform/Models/AppSettings.cs 71.42% 0 Missing and 2 partials ⚠️
...on.georealtime/Models/GeoJson/GeometryBaseModel.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
- Coverage   94.77%   94.70%   -0.07%     
==========================================
  Files         576      590      +14     
  Lines       20298    20472     +174     
  Branches     3165     3183      +18     
==========================================
+ Hits        19238    19389     +151     
- Misses        693      709      +16     
- Partials      367      374       +7
Flag Coverage Δ
all 94.70% <88.17%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

10 New issues
0 Security Hotspots
87.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@qdraw qdraw added this to the Release 0.6.x (after 0) milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.6.x (after 0)
Development

Successfully merging this pull request may close these issues.
1 participant
@qdraw